FTBFS on Sparc (Fwd: mscore in Debian)

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

FTBFS on Sparc (Fwd: mscore in Debian)

Toby Smithe-2
Here is a patch I got from my Debian sponsor for fixing FTBFSes on
some multi-core architectures. I was wondering if you had any better
thoughts on the fix: a better way to detect multiple CPUs, perhaps?
Just disabling concurrency in this way, whilst not the end of the
world, is not as efficient as we could be.

Perhaps we could use
CPUS = `dmesg | grep -c "CPU#"`? Seems to function on my system, but
it's still a bit kludgy...

--- a/Makefile
+++ b/Makefile
@@ -19,7 +19,7 @@
 #=============================================================================

 REVISION  = `cat mscore/mscore/revision.h`
-CPUS      = `grep -c processor /proc/cpuinfo`
+#CPUS      = `grep -c processor /proc/cpuinfo`
 PREFIX    = "/usr/local"
 #VERSION   = "0.9.2b${REVISION}"
 VERSION   = 0.9.2
@@ -36,7 +36,8 @@ release:
                ../mscore;       \
             make lupdate;                              \
             make lrelease;                             \
-            make -j ${CPUS};                           \
+            #make -j ${CPUS};                           \
+            make;                                      \
          else                                          \
             echo "build directory does already exist, please remove
first with 'make clean'"; \
          fi;

---------- Forwarded message ----------
From: Tobias Toedter <[hidden email]>
Date: Tue, Jun 17, 2008 at 10:15 AM
Subject: mscore in Debian
To: Toby Smithe <[hidden email]>


Hi Toby,

I've noticed that mscore is currently failing to build on some architectures.
The reason is that upstream's method of detecting multiple CPUs is not very
robust. For example, on sparc, the call "grep -c processor /proc/cpuinfo"
returns "0", so that the build gets called with "make -j 0", which in turn
results in an error.

I've attached a fix for this by disabling the use of multiple CPUs. If you
agree with this, I would prepare another upload for the package.

Regards,
Tobias

--
Tobias Toedter   | If anything can go wrong, it will.
Hamburg, Germany |

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer

disable-multiple-jobs.diff (3K) Download Attachment
signature.asc (258 bytes) Download Attachment