Quantcast

Gate time to each note of an ornament?

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Gate time to each note of an ornament?

Maurizio M. Gavioli
This post has NOT been accepted by the mailing list yet.
If am not mistaken, looking at this point in libmscore/rendermidi.cpp:

https://github.com/musescore/MuseScore/blob/master/libmscore/rendermidi.cpp#L1381

it seems to me that the instrument gate time (the shortening of the note to 95% for non-legato, and the like) is applied to each play event making an ornament up.

Is this expected? I would suppose the various elements of an ornament to be played legato; I'm pretty sure it is so for all bowed string and wind instruments and I suspect to be so for the organ too and for pitched percussions. For plucked strings (including harpsichord) I do not think it makes a real difference (even more: IIRC, on guitars and lutes, most ornaments are not even plucked, but played only with the left hand). I have no idea about piano but, in case, it would be the (more or less) only odd ball of the pack.

Wouldn't it be better to shorten only the last event of each note? And not by a percentage of ITS own duration, but by a percentage of the whole duration of the note?

Thanks,

M.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Gate time to each note of an ornament?

Maurizio M. Gavioli
This post has NOT been accepted by the mailing list yet.
It seems this post had problems with the mailing list, so I am trying to send it again. Apologies for any duplication.

If am not mistaken, looking at this point in libmscore/rendermidi.cpp:

https://github.com/musescore/MuseScore/blob/master/libmscore/rendermidi.cpp#L1381

it seems to me that the instrument gate time (the shortening of the note to 95% for non-legato, and the like) is applied to each play event making an ornament up.

Is this expected? I would suppose the various elements of an ornament to be played legato; I'm pretty sure it is so for all bowed string and wind instruments and I suspect to be so for the organ too and for pitched percussions. For plucked strings (including harpsichord) I do not think it makes a real difference (even more: IIRC, on guitars and lutes, most ornaments are not even plucked, but played only with the left hand). I have no idea about piano but, in case, it would be the (more or less) only odd ball of the pack.

Wouldn't it be better to shorten only the last event of each note? And not by a percentage of ITS own duration, but by a percentage of the whole duration of the note?

Thanks,

M.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Gate time to each note of an ornament?

Jim Newton
Hi M, why do you think this?  Is it just from looking at the code, or is it from examining the midi output?  It is something I really didn't understand when working on the ornaments.  If it's wrong it would be good to fix it.
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Gate time to each note of an ornament?

Maurizio M. Gavioli
Jim Newton wrote
Hi M, why do you think this?  Is it just from looking at the code, or is it from examining the midi output?  It is something I really didn't understand when working on the ornaments.  If it's wrong it would be good to fix it.
Sorry for being late in answering (August is not the most productive month down here...). The code, the piano roll and the MIDI output are all consistent: each play event of an ornament is 'time-gated' to the percentage which should apply to the entire note.

I do not think this to be correct and I have changed it in my PR https://github.com/musescore/MuseScore/pull/2132 (which re-introduces the on-time and off-time offsets for individual notes). In it, the total time available to the note is 'time-gated' according to the instrument requirements and this total time is divided among the various play events making up the ornament which are all legato (each takes the whole time slot it is assigned to).

Loading...