How to import file with missing drum set

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

How to import file with missing drum set

Leon Vinken
This question concerns a pert of MuseScore that I am not familiar with. Issue 55436 contains two files where drum parts are present but no drum set definition is available. Currently the MusicXML importer handles this situation by setting the staff type to percussion but it does not create a drum set for the instrument in this staff.

Question is: is this the best strategy to handle this situation, or is there a better way ? E.g. would it be better to assume standard MIDI mapping for the drum set and create a default set ?
Reply | Threaded
Open this post in threaded view
|

Re: How to import file with missing drum set

lasconic
Administrator
I don't know all the ins and outs if the problem you are trying to fight. But there is a default drumset globally defined, smDrumset. You could use it. I know the guitar pro import uses the other one gpDrumset. 

lasconic

2015-04-12 10:56 GMT+02:00 Leon Vinken <[hidden email]>:
This question concerns a pert of MuseScore that I am not familiar with. Issue
55436 contains two files where drum parts are present but no drum set
definition is available. Currently the MusicXML importer handles this
situation by setting the staff type to percussion but it does not create a
drum set for the instrument in this staff.

Question is: is this the best strategy to handle this situation, or is there
a better way ? E.g. would it be better to assume standard MIDI mapping for
the drum set and create a default set ?



--
View this message in context: http://dev-list.musescore.org/How-to-import-file-with-missing-drum-set-tp7579160.html
Sent from the MuseScore Developer mailing list archive at Nabble.com.

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: How to import file with missing drum set

Leon Vinken
After thinking about this for about a week, I still cannot imagine any structural solution for this issue. As it leads to the crash described in issue 55501, I very would like to have it fixed (or at least worked around) in 2.0.1. The reason it is difficult to fix is that the MusicXML file simply does not contain the drum set mapping (translation from symbol on a staff line to drum instrument). I would prefer to both fix the crash and import the parts as working percussion parts.

Possible solutions (sorted on amount of effort) could be:

Import the part as percussion part but ignore notes if the drum set mapping is not known. Very easy, but for the files attached to issue 55436 (note: generated by a recent Sibelius version, not some obscure program) the drum parts will be empty.

Import the part as a regular (non-percussion) part. This is relatively easy to implement, places all notes correctly and conforms with the MusicXML spec, but results in a part that does not behave or sound as a drum part. This is the solution used by Finale NotePad.

Import the part as a percussion part and try to guess the drum set mapping, e.g. by assuming the MuseScore default drum set is similar. This is a lot more work, probably results in a somewhat working percussion part, is strictly speaking not conform the spec and very well may result in drum instruments that are incorrectly mapped (and thus sound incorrect).

Unless someone has a better idea, I will try to implement the second option within a few days and hope to be in time for 2.0.1.

Reply | Threaded
Open this post in threaded view
|

Re: How to import file with missing drum set

Marc Sabatella
Not crashing beats crashing, and some notes imported beats no notes imported, so I like #2 just fine for now.  I don't really understand the scope of this though.  Do some MusicXML files have the necessary information, but others don't?  Is the case that nothing exported from Sibelius will have it, or was there something unique about that particular score?

On Thu, Apr 16, 2015 at 11:16 PM, Leon Vinken <[hidden email]> wrote:
After thinking about this for about a week, I still cannot imagine any
structural solution for this issue. As it leads to the crash described in
issue 55501, I very would like to have it fixed (or at least worked around)
in 2.0.1. The reason it is difficult to fix is that the MusicXML file simply
does not contain the drum set mapping (translation from symbol on a staff
line to drum instrument). I would prefer to both fix the crash and import
the parts as working percussion parts.

Possible solutions (sorted on amount of effort) could be:

Import the part as percussion part but ignore notes if the drum set mapping
is not known. Very easy, but for the files attached to issue 55436 (note:
generated by a recent Sibelius version, not some obscure program) the drum
parts will be empty.

Import the part as a regular (non-percussion) part. This is relatively easy
to implement, places all notes correctly and conforms with the MusicXML
spec, but results in a part that does not behave or sound as a drum part.
This is the solution used by Finale NotePad.

Import the part as a percussion part and try to guess the drum set mapping,
e.g. by assuming the MuseScore default drum set is similar. This is a lot
more work, probably results in a somewhat working percussion part, is
strictly speaking not conform the spec and very well may result in drum
instruments that are incorrectly mapped (and thus sound incorrect).

Unless someone has a better idea, I will try to implement the second option
within a few days and hope to be in time for 2.0.1.





--
View this message in context: http://dev-list.musescore.org/How-to-import-file-with-missing-drum-set-tp7579160p7579181.html
Sent from the MuseScore Developer mailing list archive at Nabble.com.

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer



--
Marc Sabatella
[hidden email]

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: How to import file with missing drum set

Leon Vinken
My collection of MusicXML files generated by Sibelius is rather small, but it would seem at least all Sibelius 7.x files with percussion parts suffer from this and thus crash 2.0 when imported.
Reply | Threaded
Open this post in threaded view
|

Re: How to import file with missing drum set

Marc Sabatella
Then my vote is quick fix based on option two now, but see what we can do with respect to option three for 2.1 in the fall if at all possible.

Marc

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: How to import file with missing drum set

lasconic
Administrator
I agree with Marc.

lasconic

2015-04-17 21:03 GMT+02:00 Marc Sabatella <[hidden email]>:
Then my vote is quick fix based on option two now, but see what we can do with respect to option three for 2.1 in the fall if at all possible.

Marc

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer



------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: How to import file with missing drum set

Leon Vinken
Pull request #1956
Reply | Threaded
Open this post in threaded view
|

Re: How to import file with missing drum set

Leon Vinken
A kind reminder to @lasconic: please do not forget to cherry-pick this fix and sync it to 2.0.1.

If this does not get included, 2.0.1 will crash on importing any MusicXML file with a percussion part generated by Sibelius using direct export.
Reply | Threaded
Open this post in threaded view
|

Re: How to import file with missing drum set

lasconic
Administrator
Thank you for the reminder. Done.

lasconic

2015-04-21 22:05 GMT+02:00 Leon Vinken <[hidden email]>:
A kind reminder to @lasconic: please do not forget to cherry-pick this fix
and sync it to 2.0.1.

If this does not get included, 2.0.1 will crash on importing any MusicXML
file with a percussion part generated by Sibelius using direct export.



--
View this message in context: http://dev-list.musescore.org/How-to-import-file-with-missing-drum-set-tp7579160p7579190.html
Sent from the MuseScore Developer mailing list archive at Nabble.com.

------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer