Introduction

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

Introduction

John Pirie
Hello all,

I'm one of the students who has been accepted to work on the
Musescore project as part of Google Summer of Code 2014! I'll be
working on improving the support for Guitar Pro imports, so if anyone
has any questions or comments on that then feel free to get in touch
on this list or on IRC (I'm there with the nick 'jpirie'). I'll
cross-post this to the forum so you can grab me there also.

For anyone interested in following the work involved in this, I've put
my blog at [1], which shall contain entries detailing how
things are progressing. My fork of Musescore is present at [2], so if
anyone is dying to view GPX files you should see support for them
appearing in the gpx-file-support branch sometime in the near future,
and I'll put pull requests in to the main repository as soon as it's
usable in any way and stable.


Thanks!

John


------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: Introduction

Maurizio M. Gavioli
Hello John,

Thanks for the intro and welcome aboard!

I'm the person assigned as mentor to your project; I saw you already walked a good way on yourself, but do not hesitate to contact me at any moment: in the MuseScore fora and in the IRC #musescore channel, I go under the nickname Miwarre, and here and at Github under my real name.

Being the original implementor of tab support in Musescore 2.0, I'm of course familiar with that part of the code; however I know little about Guitar Pro and about modern guitar(s) in general (my interest is in historic tablatures: lute, viol and so on...); so, your knowledge will be primary in these areas.

I'm confident this project will be successful and a useful addition to MuseScore features.

Maurizio
Reply | Threaded
Open this post in threaded view
|

Re: Introduction

John Pirie


On 23 Apr 2014 09:26, "Maurizio M. Gavioli" <[hidden email]> wrote:
>
> Hello John,

Hello!

> Thanks for the intro and welcome aboard!
>
> I'm the person assigned as mentor to your project; I saw you already walked
> a good way on yourself, but do not hesitate to contact me at any moment: in
> the MuseScore fora and in the IRC #musescore channel, I go under the
> nickname Miwarre, and here and at Github under my real name.
>
> Being the original implementor of tab support in Musescore 2.0, I'm of
> course familiar with that part of the code; however I know little about
> Guitar Pro and about modern guitar(s) in general (my interest is in historic
> tablatures: lute, viol and so on...); so, your knowledge will be primary in
> these areas.

Fantastic, sounds good. My plan for now is to follow the timeline outlined in my proposal which can of course be adjusted, so I'm starting with fixing the GP-related bugs already reported in the Musescore issue tracker, and then around the start of May I'll continue the work I've done on the Guitar Pro 6 (GPX) format.

If you have any comments/questions on what I'm doing or the order I'm doing things in then of course feel free to contact me, I'm on IRC at most times of the day (my timezone is UTC+1) and frequently accessing e-mail.

> I'm confident this project will be successful and a useful addition to
> MuseScore features.

Great! Thanks for the e-mail Maurizio. :-)

John


> Maurizio
>
>
>
> --
> View this message in context: http://dev-list.musescore.org/Introduction-tp7578717p7578718.html
> Sent from the MuseScore Developer mailing list archive at Nabble.com.
>
> ------------------------------------------------------------------------------
> Start Your Social Network Today - Download eXo Platform
> Build your Enterprise Intranet with eXo Platform Software
> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
> Get Started Now And Turn Your Intranet Into A Collaboration Platform
> http://p.sf.net/sfu/ExoPlatform
> _______________________________________________
> Mscore-developer mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: Introduction

chen lung
Hi John

Welcome and good work :).

I was hesitant to pounce if you are exploring things in a certain way, but here goes!

1. Would it be the right time to submit reports on GPX?

2. Some things you maybe unaware of:

There are issues without a Guitar Pro tag (such as this).

It might be worth performing a search in the issue tracker (or whatever), if you haven't.

There are threads about Guitar Pro which were posted in the Technology Preview section to invite further comment (possibly due to lack of knowledge):

http://musescore.org/en/node/21684
http://musescore.org/en/node/21699
http://musescore.org/en/node/24653
Scott
Reply | Threaded
Open this post in threaded view
|

Re: Introduction

John Pirie
On 7 August 2014 17:04, chen lung <[hidden email]> wrote:
Hi John

Welcome and good work :).

Hello, and thanks!
 
I was hesitant to pounce if you are exploring things in a certain way, but
here goes!

1. Would it be the right time to submit reports on GPX?

Almost; I have a pull request in at the moment that adds a lot of new features and fixes. When that is merged, then certainly it's time to start finding any issues and putting them in the bug-tracker. There are a few enhancements I need to make to that PR before it is merged, I intend to look at these tomorrow.

I'm closing the bug that generally describes that GPX files are not supported, so that we don't end up with distinct issues under the same bug, it would be nice to have separate bug reports for each feature which doesn't work as intended.

Generally, larger GPX files are something I haven't been testing with as it's often small individual test cases that I've been using to identify and create support for each unsupported feature. While everything should work in the larger case in a non-toy score, there are bound to be issues to find and fix there as there's been less testing in that area.
 
2. Some things you maybe unaware of:

There are issues without a Guitar Pro tag (such as  this
<http://musescore.org/en/node/22438>  ).

It might be worth performing a search in the issue tracker (or whatever), if
you haven't.

These non-tagged bugs are not specific to Guitar Pro (somebody leap in and correct me otherwise) and are really bugs which either:

- Affect how text affects other score elements. Unless we want to do something special with the Guitar Pro case of this, then this bug should probably be edited to describe the issue as a whole as this issue applies to Musescore as a whole.

- Beaming, which I think should probably be closed as 'by design'. I'm not sure that a machinery to modify how beaming is done in Musescore is beneficial and sounds overly-complicated, and ascertaining how Guitar Pro does this in all cases could be inherently fiddly.

Certainly welcome all contrasting views though!
 
There are threads about Guitar Pro which were posted in the Technology
Preview section to invite further comment (possibly due to lack of
knowledge):

http://musescore.org/en/node/21684

This one has certainly attracted discussion. Perhaps there should be a user option whether or not parts should be created (maybe there already is and I'm unaware of it). This is perhaps an issue that extends beyond Guitar Pro, presumably importing from XML brings up the same questions. I'm not sure there's a right or wrong answer here, and what the general consensus is on this subject.


http://musescore.org/en/node/21699

I do think this report is probably still valid. I shall think about this, thanks!
 

http://musescore.org/en/node/24653

Artificial harmonics should be supported in the new pull request (artificial-harmonic.gpx test case). I notice the appropriate functions still needs to be called by other Guitar Pro versions (one of my current active tasks is checking that features that have now been added are support in all relevant Guitar Pro versions and that none have been missed out - this should be a minor change as the work has been done for another format so the machinery is there). Certainly they are not supported in Guitar Pro 3 as I cannot locate a copy of Guitar Pro 4 [1] any longer (Guitar Pro supports exporting to one version previous from its current version). With the test case you have provided there, I should be able to build a solution for that version of Guitar Pro too, I will look at this - thanks!

Aside from an issue with key signatures (warnings generated at run-time, but correct on the score), after I've resolved the issues with the current pull request and it's merged then all features should be supported in Guitar Pro 6 too. If something doesn't work in any Guitar Pro version at that point then it's a bug and we should keep track of that in the bug tracker. I'll be doing as much testing as I can next week to detect and resolve any issues.

Any other comments fire away! Thanks for your comments so far. :-)

John

[1] TuxGuitar can export to GP3 but I realized early on that it is not a faithful implementation of Guitar Pro. I'm focusing support on 4, 5 and 6 and that's what Guitar Pro versions I have found to be available. That said, generally if something works for version 3 it's very similar in version 4 and adding support is easy so I'm happy to make any necessary changes to that format if we have a test case for it. 





-----
Scott
--
View this message in context: http://dev-list.musescore.org/Introduction-tp7578717p7578884.html
Sent from the MuseScore Developer mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: Introduction

m3guitar
In reply to this post by John Pirie
I have 500+ Guitar Pro examples on my website I need to convert to MuseScore so as a tester I can be your best friend / worst nightmare. Is the current version ready for feedback? Is the left hand fingering there?
Reply | Threaded
Open this post in threaded view
|

Re: Introduction

John Pirie
Ah good, I always look forward to a new best friend who is also my worst nightmare! :-)

I would hold off on creating the relevant bug reports until my next PR goes in as there are lot of new features and edits to existing ones that have been made. I'll try and get time over the weekend so that it can be merged on Monday and I can get the whole week to do bug-shooting. Fingering is not supported in the current master no, but there will be support for that with the next PR.

Thanks!

John


On 8 August 2014 17:28, m3guitar <[hidden email]> wrote:
I have 500+ Guitar Pro examples on my website I need to convert to MuseScore
so as a tester I can be your best friend / worst nightmare. Is the current
version ready for feedback? Is the left hand fingering there?



--
View this message in context: http://dev-list.musescore.org/Introduction-tp7578717p7578886.html
Sent from the MuseScore Developer mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: Introduction

m3guitar
How do I know when you have made a new commit available for testing?
Reply | Threaded
Open this post in threaded view
|

Re: Introduction

John Pirie
I will post here when the latest features are in the master and testing can begin. (For each new commit/PR I'm not sure if you can get notifications for all changes by a specific user on Github, perhaps If This Then That (ifttt.com) will be useful there or maybe Github has some functionality for that I'm unaware of.)

Thanks,

John


On 8 August 2014 18:48, m3guitar <[hidden email]> wrote:
How do I know when you have made a new commit available for testing?



--
View this message in context: http://dev-list.musescore.org/Introduction-tp7578717p7578888.html
Sent from the MuseScore Developer mailing list archive at Nabble.com.

------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------

_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: Introduction

m3guitar
That was exactly the answer I was fishing for . Thank you!
Reply | Threaded
Open this post in threaded view
|

Re: Introduction

John Pirie
Hello, I said I'd post here when it was time to test everything. PRs related to crashes have all been merged so feel free to fire in individual bug reports in on Guitar Pro files where something unexpected is displayed or if you think anything is missing.

Cheers!

John


On 10 August 2014 15:23, m3guitar <[hidden email]> wrote:
That was exactly the answer I was fishing for . Thank you!



--
View this message in context: http://dev-list.musescore.org/Introduction-tp7578717p7578891.html
Sent from the MuseScore Developer mailing list archive at Nabble.com.

------------------------------------------------------------------------------
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer