Is Score::cropPage() obsolete?
Locked
 
|
I can find nowhere in the MuseScore code that calls Score::cropPage() in
score.cpp. But it is declared in score.h as Q_INVOKABLE, and I'm not familiar enough with that to understand if it's getting called in ways that I can't see, or don't know how to see. I created a branch of the latest master that removes it in score.cpp and score.h. It compiles and runs, but I'm not even sure what to test for. If it really is obsolete, I can create a PR from this branch to remove it. AFAIK, cropPage() has not been in use since the beginning of v2. It was a simple exercise, and I've posted my branch here, if you care to see the specific code that changes: https://github.com/musescore/MuseScore/compare/master...sidewayss:cropPageNoMore -- Sideways ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Mscore-developer mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/mscore-developer |
Re: Is Score::cropPage() obsolete?
|
It is is Q_INVOCABLE, it can be used in plugins.
-----Original Message----- From: Sideways Skullfinger [mailto:[hidden email]] Sent: Monday, April 25, 2016 8:03 PM To: [hidden email] Subject: [Mscore-developer] Is Score::cropPage() obsolete? I can find nowhere in the MuseScore code that calls Score::cropPage() in score.cpp. But it is declared in score.h as Q_INVOKABLE, and I'm not familiar enough with that to understand if it's getting called in ways that I can't see, or don't know how to see. I created a branch of the latest master that removes it in score.cpp and score.h. It compiles and runs, but I'm not even sure what to test for. If it really is obsolete, I can create a PR from this branch to remove it. AFAIK, cropPage() has not been in use since the beginning of v2. It was a simple exercise, and I've posted my branch here, if you care to see the specific code that changes: https://github.com/musescore/MuseScore/compare/master...sidewayss:cropPageNo More -- Sideways ---------------------------------------------------------------------------- -- Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Mscore-developer mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/mscore-developer ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Mscore-developer mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/mscore-developer |
|
|
Now it's starting to make sense, thanks. Along those same lines, I'm
assuming that these 2 are also related to plugins: #ifdef SCRIPT_INTERFACE and Q_PROPERTY() -- Sideways On 4/25/2016 12:35 PM, Joachim Schmitz wrote: > It is is Q_INVOCABLE, it can be used in plugins. > > -----Original Message----- > From: Sideways Skullfinger [mailto:[hidden email]] > Sent: Monday, April 25, 2016 8:03 PM > To: [hidden email] > Subject: [Mscore-developer] Is Score::cropPage() obsolete? > > I can find nowhere in the MuseScore code that calls Score::cropPage() in > score.cpp. But it is declared in score.h as Q_INVOKABLE, and I'm not > familiar enough with that to understand if it's getting called in ways that > I can't see, or don't know how to see. > > I created a branch of the latest master that removes it in score.cpp and > score.h. It compiles and runs, but I'm not even sure what to test for. > If it really is obsolete, I can create a PR from this branch to remove it. > AFAIK, cropPage() has not been in use since the beginning of v2. > > It was a simple exercise, and I've posted my branch here, if you care to see > the specific code that changes: > https://github.com/musescore/MuseScore/compare/master...sidewayss:cropPageNo > More > > -- > Sideways > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Mscore-developer mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/mscore-developer |
Re: Is Score::cropPage() obsolete?
|
|
Yes indeed ---- Sideways Skullfinger schrieb ---- Now it's starting to make sense, thanks. Along those same lines, I'm assuming that these 2 are also related to plugins: #ifdef SCRIPT_INTERFACE and Q_PROPERTY() -- Sideways On 4/25/2016 12:35 PM, Joachim Schmitz wrote: > It is is Q_INVOCABLE, it can be used in plugins. > > -----Original Message----- > From: Sideways Skullfinger [mailto:[hidden email]] > Sent: Monday, April 25, 2016 8:03 PM > To: [hidden email] > Subject: [Mscore-developer] Is Score::cropPage() obsolete? > > I can find nowhere in the MuseScore code that calls Score::cropPage() in > score.cpp. But it is declared in score.h as Q_INVOKABLE, and I'm not > familiar enough with that to understand if it's getting called in ways that > I can't see, or don't know how to see. > > I created a branch of the latest master that removes it in score.cpp and > score.h. It compiles and runs, but I'm not even sure what to test for. > If it really is obsolete, I can create a PR from this branch to remove it. > AFAIK, cropPage() has not been in use since the beginning of v2. > > It was a simple exercise, and I've posted my branch here, if you care to see > the specific code that changes: > https://github.com/musescore/MuseScore/compare/master...sidewayss:cropPageNo > More > > -- > Sideways > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Mscore-developer mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/mscore-developer ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Mscore-developer mailing list [hidden email] https://lists.sourceforge.net/lists/listinfo/mscore-developer |
«
Return to MuseScore Developer
|
1 view|%1 views
| Free forum by Nabble | Edit this page |