MusicXML clef export broken

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

MusicXML clef export broken

Leon Vinken
Werner, Nicolas,

in the master, MusicXML clef export is broken. I suspect this may be caused by the introduction of Segment::Type::HeaderClef in commit f7d9650.

Would you like me to investigate and fix ?

Regards, Leon.
Reply | Threaded
Open this post in threaded view
|

Re: MusicXML clef export broken

lasconic
Administrator

Sure, go ahead. I believe this new segment construct is quite stable. Werner might have some input.

Unfortunately, the music XML tests are entirely commented right now. You might want to uncomment some before changing anything...

Lasconic


------------------------------------------------------------------------------

_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: MusicXML clef export broken

lasconic
Administrator
Hi Leon,

I fixed the MusicXML mtests and now I realize that might be what caused your bug report...

lasconic

2016-11-19 11:53 GMT+01:00 Lasconic <[hidden email]>:

Sure, go ahead. I believe this new segment construct is quite stable. Werner might have some input.

Unfortunately, the music XML tests are entirely commented right now. You might want to uncomment some before changing anything...

Lasconic



------------------------------------------------------------------------------

_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: MusicXML clef export broken

Leon Vinken
Just tested the latest and greatest (commit aeb0d5b): all MusicXML regression test are indeed OK, will close #141601.

I assume the actual fix is part of commit 63f5d73, which looks similar to my intended changes.

Thanks, Leon.