Reviewing Code

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Reviewing Code

nalin18
Hi,
I just fixed Issue #36971(Style for both Instrument Name And Lyricist collide).
I am a newbie so just want to make sure if what I did really corrects the problem or not.


I changed the line 271 (AlignmentFlags to LEFT And TOP) as mentioned in the issue.
Here is the patch.

Thank You.

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer

style.cpp (114K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Reviewing Code

lasconic
Administrator
Hi Nalin,

The best way to contribute a change is via Git. See
http://musescore.org/en/developers-handbook/git-workflow
If you need help with this workflow, feel free to ask here or on IRC
#musescore on freenode.net
https://kiwiirc.com/client/irc.freenode.net/?nick=musescore|?#musescore

lasconic

2014-10-19 15:46 GMT+02:00 Nalin Goel <[hidden email]>:

> Hi,
> I just fixed Issue #36971(Style for both Instrument Name And Lyricist
> collide).
> I am a newbie so just want to make sure if what I did really corrects the
> problem or not.
>
>
> I changed the line 271 (AlignmentFlags to LEFT And TOP) as mentioned in the
> issue.
> Here is the patch.
>
> Thank You.
>
> ------------------------------------------------------------------------------
> Comprehensive Server Monitoring with Site24x7.
> Monitor 10 servers for $9/Month.
> Get alerted through email, SMS, voice calls or mobile push notifications.
> Take corrective actions from your mobile device.
> http://p.sf.net/sfu/Zoho
> _______________________________________________
> Mscore-developer mailing list
> [hidden email]
> https://lists.sourceforge.net/lists/listinfo/mscore-developer
>

------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: Reviewing Code

Jojo-Schmitz
In reply to this post by nalin18

I’ve now submitted a PR for this.

I wasn’t too sure how best to fix it, but now I’ll go for LEFT|TOP

 

Bye, Jojo

 

From: Nalin Goel [mailto:[hidden email]]
Sent: Sunday, October 19, 2014 3:47 PM
To: [hidden email]
Subject: [Mscore-developer] Reviewing Code

 

Hi,

I just fixed Issue #36971(Style for both Instrument Name And Lyricist collide).

I am a newbie so just want to make sure if what I did really corrects the problem or not.

 

 

I changed the line 271 (AlignmentFlags to LEFT And TOP) as mentioned in the issue.

Here is the patch.

 

Thank You.


------------------------------------------------------------------------------
Comprehensive Server Monitoring with Site24x7.
Monitor 10 servers for $9/Month.
Get alerted through email, SMS, voice calls or mobile push notifications.
Take corrective actions from your mobile device.
http://p.sf.net/sfu/Zoho
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer