Quantcast

Support for numbered notation (Jianpu)

classic Classic list List threaded Threaded
42 messages Options
123
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Support for numbered notation (Jianpu)

Brian Yan
I pushed Jianpu code changes to github master and it seemed to be successful (see below).
But the changes did not show up at MuseScore github on web browser.
When I clicked "New pull request" and tried to compare with master branch, it said they were identical.
Did I do something wrong or am I missing something?

-----------------------------------------------------------
byan@byan-laptop:/shared/Projects/Opensource/MuseScore$ git commit -m "[141581-jianpu] Initial implementation of Jianpu linked staff display."
[master 7723f60] [141581-jianpu] Initial implementation of Jianpu linked staff display.
37 files changed, 1813 insertions(+), 64 deletions(-)
create mode 100644 libmscore/jianpubeam.cpp
create mode 100644 libmscore/jianpubeam.h
create mode 100644 libmscore/jianpuchord.cpp
create mode 100644 libmscore/jianpuchord.h
create mode 100644 libmscore/jianpufactory.cpp
create mode 100644 libmscore/jianpufactory.h
create mode 100644 libmscore/jianpuhook.cpp
create mode 100644 libmscore/jianpuhook.h
create mode 100644 libmscore/jianpunote.cpp
create mode 100644 libmscore/jianpunote.h
create mode 100644 libmscore/jianpurest.cpp
create mode 100644 libmscore/jianpurest.h
create mode 100644 libmscore/stafffactory.h
byan@byan-laptop:/shared/Projects/Opensource/MuseScore$ git push origin master
Enter passphrase for key '/home/byan/.ssh/id_rsa':
Counting objects: 41, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (41/41), done.
Writing objects: 100% (41/41), 20.74 KiB | 0 bytes/s, done.
Total 41 (delta 31), reused 0 (delta 0)
remote: Resolving deltas: 100% (31/31), completed with 27 local objects.
To [hidden email]
b7a53fc..7723f60 master -> master
byan@byan-laptop:/shared/Projects/Opensource/MuseScore$
-----------------------------------------------------------


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Support for numbered notation (Jianpu)

lasconic
Administrator
If you do
git push origin master
Git will push your local master branch to the origin (your github fork of MuseScore).

If you did it correctly, you didn't work on your local master branch but on a feature branch (maybe 141581-jianpu ?)
Then you should run:  git push origin 141581-jianpu
And then you should be able to do a pull request of your branch to MuseScore master.

lasconic

2017-01-08 9:23 GMT+01:00 Brian Yan <[hidden email]>:
I pushed Jianpu code changes to github master and it seemed to be successful (see below).
But the changes did not show up at MuseScore github on web browser.
When I clicked "New pull request" and tried to compare with master branch, it said they were identical.
Did I do something wrong or am I missing something?

-----------------------------------------------------------
byan@byan-laptop:/shared/Projects/Opensource/MuseScore$ git commit -m "[141581-jianpu] Initial implementation of Jianpu linked staff display."
[master 7723f60] [141581-jianpu] Initial implementation of Jianpu linked staff display.
37 files changed, 1813 insertions(+), 64 deletions(-)
create mode 100644 libmscore/jianpubeam.cpp
create mode 100644 libmscore/jianpubeam.h
create mode 100644 libmscore/jianpuchord.cpp
create mode 100644 libmscore/jianpuchord.h
create mode 100644 libmscore/jianpufactory.cpp
create mode 100644 libmscore/jianpufactory.h
create mode 100644 libmscore/jianpuhook.cpp
create mode 100644 libmscore/jianpuhook.h
create mode 100644 libmscore/jianpunote.cpp
create mode 100644 libmscore/jianpunote.h
create mode 100644 libmscore/jianpurest.cpp
create mode 100644 libmscore/jianpurest.h
create mode 100644 libmscore/stafffactory.h
byan@byan-laptop:/shared/Projects/Opensource/MuseScore$ git push origin master
Enter passphrase for key '/home/byan/.ssh/id_rsa':
Counting objects: 41, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (41/41), done.
Writing objects: 100% (41/41), 20.74 KiB | 0 bytes/s, done.
Total 41 (delta 31), reused 0 (delta 0)
remote: Resolving deltas: 100% (31/31), completed with 27 local objects.
To [hidden email]
b7a53fc..7723f60 master -> master
byan@byan-laptop:/shared/Projects/Opensource/MuseScore$
-----------------------------------------------------------


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
123
Loading...