Quantcast

Which name for modification: Allow tablature lines to have fingerings?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Which name for modification: Allow tablature lines to have fingerings?

MLutz
Hello,
as this is my first contribution  to musescore, I'm a little bit unsure,
how to get this into a correct pull request.

On my laptop I have built a version of the 3.0-devel musescore with the
possibility to allow fingerings on tablature lines (see discussion on
https://musescore.org/en/node/94976). I have added it to "General
Style/Score" under "Hide instrument name if ...".
It seems to work as it should (I hope at least).

But what name should I give this modification, as it is doesn't seem to
have an issue-number, as far as I know?

Unfortunately I first have also to clone my repository here, like I
already did on my other computer.

Best regards
Markus



--

Markus Lutz
Schulstraße 11

88422 Bad Buchau

Tel  0 75 82 / 92 62 89
Fax  0 75 82 / 92 62 90
Mail [hidden email]


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Which name for modification: Allow tablature lines to have fingerings?

Jojo-Schmitz
Hi Markus

You mean how to name the branch? This isn't really important, it is just a
name, I'd suggest tablatur-fingerings.
And in the commit message's comment just mention that discussion URL. Or
create an issue for this and mention that in the commit title "fix #xxxxx:
allow fingerings in tablature" or some such.
Having an issue for this is probably better for tracking purposes

Bye, Jojo

-----Original Message-----
From: Markus Lutz [mailto:[hidden email]]
Sent: Tuesday, February 21, 2017 11:49 PM
To: [hidden email]
Subject: [Mscore-developer] Which name for modification: Allow tablature
lines to have fingerings?

Hello,
as this is my first contribution  to musescore, I'm a little bit unsure, how
to get this into a correct pull request.

On my laptop I have built a version of the 3.0-devel musescore with the
possibility to allow fingerings on tablature lines (see discussion on
https://musescore.org/en/node/94976). I have added it to "General
Style/Score" under "Hide instrument name if ...".
It seems to work as it should (I hope at least).

But what name should I give this modification, as it is doesn't seem to have
an issue-number, as far as I know?

Unfortunately I first have also to clone my repository here, like I already
did on my other computer.

Best regards
Markus



--

Markus Lutz
Schulstraße 11

88422 Bad Buchau

Tel  0 75 82 / 92 62 89
Fax  0 75 82 / 92 62 90
Mail [hidden email]


----------------------------------------------------------------------------
--
Check out the vibrant tech community on one of the world's most engaging
tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Which name for modification: Allow tablature lines to have fingerings?

lasconic
Administrator
In reply to this post by MLutz
Great that you managed to compile and add your feature! Congrats!

You can create an issue yourself to explain the problem. See the link "Create a new issue" here https://musescore.org/en/project/issues/musescore  It should lead you to this page https://musescore.org/en/node/add/project-issue/musescore

Then, use the issue number in your branch name and your commit message "Fix #XXXXX: your commit message" with XXXX the issue number.

Regarding the feature itself, let's discuss it in the issue tracker once filed but I feel it would be better in Staff Properties, probably for a tablature staff only.

lasconic

2017-02-21 23:48 GMT+01:00 Markus Lutz <[hidden email]>:
Hello,
as this is my first contribution  to musescore, I'm a little bit unsure,
how to get this into a correct pull request.

On my laptop I have built a version of the 3.0-devel musescore with the
possibility to allow fingerings on tablature lines (see discussion on
https://musescore.org/en/node/94976). I have added it to "General
Style/Score" under "Hide instrument name if ...".
It seems to work as it should (I hope at least).

But what name should I give this modification, as it is doesn't seem to
have an issue-number, as far as I know?

Unfortunately I first have also to clone my repository here, like I
already did on my other computer.

Best regards
Markus



--

Markus Lutz
Schulstraße 11

88422 Bad Buchau

Tel  0 75 82 / 92 62 89
Fax  0 75 82 / 92 62 90
Mail [hidden email]


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Loading...