newline missing in test output

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

newline missing in test output

Jim Newton
This is an extremely minor issue, but I'll try to find the culprit and fix it.
When a midi test fails, I get output like the following, ie., missing a linefeed before the word FAIL.

QDEBUG : TestMidi::events(testKantataBWV140Excerpts) Running  "diff"  with arg1: "testKantataBWV140Excerpts-test.txt"  and arg2:  "libmscore/midi/testKantataBWV140Excerpts-ref.txt"
   <diff -u testKantataBWV140Excerpts-test.txt /Users/jimka/MuseScore/mtest/libmscore/midi/testKantataBWV140Excerpts-ref.txt failedFAIL!  : TestMidi::events(testKantataBWV140Excerpts) 'compareFiles(writeFile, reference)' returned FALSE. ()
   Loc: [/Users/jimka/MuseScore/mtest/libmscore/midi/tst_midi.cpp(368)]
QDEBUG : TestMidi::events(testTrillTransposingInstrument) ChordList::read failed: </Users/jimka/MuseScore/build.xcode/mtest/libmscore/midi/Resources/styles/chords_std.xml>
ABL
Reply | Threaded
Open this post in threaded view
|

Re: newline missing in test output

ABL
I think it is a byproduct of my PR for verbose output:
https://github.com/musescore/MuseScore/commit/83bf16bb7

Probably a simple \n at the end of the QString
QString("   <diff -u %1 %2 failed")
could give a better readibility.

Ciao,
ABL