r1366 : Chordnames bugs after change on flat/sharp

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

r1366 : Chordnames bugs after change on flat/sharp

lasconic
Administrator
Some commits ago, a change has been made to display flat and sharp in chordnames.
A bug :
Enter 4 quarter
On the first quarter, Ctrl + K, press C  press b,
Space to go the second quarter --> you will see that the chordname will be lowered when exiting this chordname
On the second quarter just a C
Exit edit mode --> The two chord name are not horizontally aligned, flated one is lower than natural one. (same for #)

Missing : flat and sharp on the root note for example in Gb/Eb only the first b becomes a flat.

------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: r1366 : Chordnames bugs after change on flat/sharp

wschweer
Administrator
Mixing two fonts in a text changes the text height. Vertical alignment in text
style must be set to "baseline" to proper align the text. I changed this in
revision 1473. The missing flat/sharp in a slash chord was an omission and is
also fixed.

On Thursday 18 December 2008 12:21:44 Lasconic wrote:

> Some commits ago, a change has been made to display flat and sharp in
> chordnames.
> A bug :
> Enter 4 quarter
> On the first quarter, Ctrl + K, press C  press b,
> Space to go the second quarter --> you will see that the chordname will be
> lowered when exiting this chordname
> On the second quarter just a C
> Exit edit mode --> The two chord name are not horizontally aligned, flated
> one is lower than natural one. (same for #)
>
> Missing : flat and sharp on the root note for example in Gb/Eb only the
> first b becomes a flat.


------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: r1366 : Chordnames bugs after change on flat/sharp

lasconic
Administrator
Perfect :) Thanks for the explanation.

2008/12/18 Werner Schweer <[hidden email]>
Mixing two fonts in a text changes the text height. Vertical alignment in text
style must be set to "baseline" to proper align the text. I changed this in
revision 1473. The missing flat/sharp in a slash chord was an omission and is
also fixed.

On Thursday 18 December 2008 12:21:44 Lasconic wrote:
> Some commits ago, a change has been made to display flat and sharp in
> chordnames.
> A bug :
> Enter 4 quarter
> On the first quarter, Ctrl + K, press C  press b,
> Space to go the second quarter --> you will see that the chordname will be
> lowered when exiting this chordname
> On the second quarter just a C
> Exit edit mode --> The two chord name are not horizontally aligned, flated
> one is lower than natural one. (same for #)
>
> Missing : flat and sharp on the root note for example in Gb/Eb only the
> first b becomes a flat.


------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: r1366 : Chordnames bugs after change on flat/sharp

lasconic
Administrator
Btw not sure at all it's the same code but there are also extensions with flat and sharp in them (G7b5)

2008/12/18 Lasconic <[hidden email]>
Perfect :) Thanks for the explanation.

2008/12/18 Werner Schweer <[hidden email]>

Mixing two fonts in a text changes the text height. Vertical alignment in text
style must be set to "baseline" to proper align the text. I changed this in
revision 1473. The missing flat/sharp in a slash chord was an omission and is
also fixed.

On Thursday 18 December 2008 12:21:44 Lasconic wrote:
> Some commits ago, a change has been made to display flat and sharp in
> chordnames.
> A bug :
> Enter 4 quarter
> On the first quarter, Ctrl + K, press C  press b,
> Space to go the second quarter --> you will see that the chordname will be
> lowered when exiting this chordname
> On the second quarter just a C
> Exit edit mode --> The two chord name are not horizontally aligned, flated
> one is lower than natural one. (same for #)
>
> Missing : flat and sharp on the root note for example in Gb/Eb only the
> first b becomes a flat.


------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer



------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer
Reply | Threaded
Open this post in threaded view
|

Re: r1366 : Chordnames bugs after change on flat/sharp

wschweer
Administrator
Its another omission. I added sharps/flats for  superscript text but there is a
small problem: they do not line up as in non superscript text. I can only
guess that there is a problem with font metrics (or qt?).

On Thursday 18 December 2008 14:39:50 Lasconic wrote:

> Btw not sure at all it's the same code but there are also extensions with
> flat and sharp in them (G7b5)
>
> 2008/12/18 Lasconic <[hidden email]>
>
> > Perfect :) Thanks for the explanation.
> >
> > 2008/12/18 Werner Schweer <[hidden email]>
> >
> > Mixing two fonts in a text changes the text height. Vertical alignment in
> >
> >> text
> >> style must be set to "baseline" to proper align the text. I changed this
> >> in
> >> revision 1473. The missing flat/sharp in a slash chord was an omission
> >> and is
> >> also fixed.
> >>
> >> On Thursday 18 December 2008 12:21:44 Lasconic wrote:
> >> > Some commits ago, a change has been made to display flat and sharp in
> >> > chordnames.
> >> > A bug :
> >> > Enter 4 quarter
> >> > On the first quarter, Ctrl + K, press C  press b,
> >> > Space to go the second quarter --> you will see that the chordname
> >> > will
> >>
> >> be
> >>
> >> > lowered when exiting this chordname
> >> > On the second quarter just a C
> >> > Exit edit mode --> The two chord name are not horizontally aligned,
> >>
> >> flated
> >>
> >> > one is lower than natural one. (same for #)
> >> >
> >> > Missing : flat and sharp on the root note for example in Gb/Eb only
> >> > the first b becomes a flat.
> >>
> >> ------------------------------------------------------------------------
> >>------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las
> >> Vegas, Nevada.
> >> The future of the web can't happen without you.  Join us at MIX09 to
> >> help pave the way to the Next Web now. Learn more and register at
> >>
> >> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.
> >>com/ _______________________________________________
> >> Mscore-developer mailing list
> >> [hidden email]
> >> https://lists.sourceforge.net/lists/listinfo/mscore-developer


------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
Mscore-developer mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/mscore-developer